yeah that's probably better. fixed


On Thu, Sep 19, 2013 at 4:28 PM, Jake Wharton <notifications@github.com>wrote:

> In src/main/java/org/robolectric/shadows/ShadowSurfaceView.java:
>
> > -      @Override public void addCallback(Callback callback) {
> > -      }
> > +    return fakeSurfaceHolder;
> > +  }
> > +
> > +  public FakeSurfaceHolder getFakeSurfaceHolder() {
> > +    return fakeSurfaceHolder;
> > +  }
> > +
> > +  /**
> > +   * Fake version of {@link SurfaceHolder} that gives access to the stored callbacks,
> > +   * so they can be called by tests.
> > +   */
> > +  public static class FakeSurfaceHolder implements SurfaceHolder {
> > +
> > +    private List<Callback> callbacks = new ArrayList<Callback>();
>
> Should this be a Set?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/robolectric/robolectric/pull/695/files#r6476350>
> .
>