Good point - since services are what get monitored. I will make the change


On Mon, Apr 29, 2013 at 1:26 PM, Wolfgang Sourdeau <notifications@github.com
> wrote:

> In plugins/data_logger/data_logger.cc:
>
> > @@ -15,11 +15,13 @@
> >  using namespace RTBKIT;
> >
> >  DataLogger::
> > -DataLogger(std::shared_ptr<ServiceProxies> proxies)
> > -    : ServiceBase("data_logger", proxies),
> > -      Logger(proxies->zmqContext),
> > +DataLogger(const string & serviceName, std::shared_ptr<ServiceProxies> proxies,
> > +           bool monitor, size_t bufferSize)
>
> Shouldn't "bool monitor" and monitor_ be a argument and a member to/of
> ServiceBase::init instead?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rtbkit/rtbkit/pull/35/files#r4003093>
> .
>