CMakeChecker takes unusually long time to run
https://bugs.webkit.org/show_bug.cgi?id=105662

Reviewed by Ryosuke Niwa.

Move the caching mechanism for regular expression of the C++ checker into
a common file and use it for the CMake and ChangeLog checkers too.

* Scripts/webkitpy/style/checkers/changelog.py:
(ChangeLogChecker.check_entry):
* Scripts/webkitpy/style/checkers/cmake.py:
(CMakeChecker._process_line):
(CMakeChecker._check_no_space_cmds):
(CMakeChecker._check_one_space_cmds):
(CMakeChecker._check_non_lowercase_cmd):
* Scripts/webkitpy/style/checkers/common.py:
(match):
(search):
(searchIgnorecase):
(sub):
(subn):
* Scripts/webkitpy/style/checkers/cpp.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r156355) Links / interactive elements inside nested tables are unclickable
https://bugs.webkit.org/show_bug.cgi?id=121904

Reviewed by Andreas Kling.

Source/WebCore: 

Test: fast/table/hittest-self-painting.html
        
Original reduction by Philippe Wittenbergh.

* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
        
    Tighten a bit.

(WebCore::RenderTableRow::nodeAtPoint):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
        
    These flipped accidentally in r156355.

LayoutTests: 

* fast/table/hittest-self-painting-expected.txt: Added.
* fast/table/hittest-self-painting.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add style checker for CMake lists
https://bugs.webkit.org/show_bug.cgi?id=121764

Reviewed by Ryosuke Niwa.

Add an additional check to make sure that list of files are sorted.
Exclude lists of include directories for now, since the order
can be importent for compilation of some files.

* Scripts/webkitpy/style/checkers/cmake.py:
(CMakeChecker.check):
(CMakeChecker._check_indent):
(CMakeChecker):
(CMakeChecker._check_list_order):
(CMakeChecker._list_item_path):
* Scripts/webkitpy/style/checkers/cmake_unittest.py:
(CMakeCheckerTest.test_check):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
More refactoring to make the LevelDB dependencies of IDB more obvious.
https://bugs.webkit.org/show_bug.cgi?id=121880

Reviewed by Alexey Proskuryakov.

This patch does three things:
1 - Moves some files to the indexeddb/leveldb subdirectory, renaming them in the process.
2 - Renames some classes.
3 - Adds "USE(LEVELDB)" guards in addition to the ENABLE(INDEXED_DATABASE) guard for those files.

Project file updates:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcxproj/WebCore.vcxproj:

File renames, class renames, and USE(LEVELDB) guards:
* Modules/indexeddb/IDBBackingStore.cpp: Removed.
* Modules/indexeddb/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create): Add a null return if USE(LEVELDB) is disabled as a stop gap measure until
  there is a non-LevelDB impl.
* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBBackingStore.h.
* Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp.
* Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.h.
* Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp.
* Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h.
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.cpp.
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.h.
* Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:
* Modules/indexeddb/leveldb/IDBLevelDBCoding.h:
* Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp.
* Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h.
* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp.
* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h.
* Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.cpp.
* Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
HasMemoryCostMemberFunction should work for final classes
https://bugs.webkit.org/show_bug.cgi?id=121747

Reviewed by Sam Weinig.

Use decltype to check for the memoryCost() member function. This doesn't check that the return type is size_t, but
the build will fail anyway if that's the case (or if the return type is not convertible to size_t).

* bindings/js/JSDOMBinding.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
CTTE: More Document references please
https://bugs.webkit.org/show_bug.cgi?id=121893

Reviewed by Anders Carlsson.

* Thread even more Document&s around. *


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
AX: WebKit doesn't map aria-sort=other on OS X
https://bugs.webkit.org/show_bug.cgi?id=118511

Patch by Sam White <samuel_white@apple.com> on 2013-09-25
Reviewed by Chris Fleizach.

Source/WebCore:

No new tests, updated existing aria-sort test to validate addition of "other"
sort order per http://www.w3.org/TR/wai-aria/complete#aria-sort.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::sortDirection):
* accessibility/AccessibilityObject.h:

LayoutTests:

Updated test to check "other" aria-sort order. Also added additional checks to
determine which elements expose aria-sort so our "none" case is more clear.

* accessibility/aria-sort-expected.txt:
* accessibility/aria-sort.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
loader/go-back-to-different-window-size.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=96642

* platform/mac/TestExpectations: Marking it as flaky on Mac. I think that it's
a general issue with the tools that window resizing doesn't work well.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Windows] Unreviewed build fix after r156408.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening. Moving around and updating the GTK baselines that are
either specific to WK1 or WK2 or can be shared by both.

* platform/gtk-wk1/http: Added.
* platform/gtk-wk1/http/tests: Added.
* platform/gtk-wk1/http/tests/cache: Added.
* platform/gtk-wk1/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Added.
* platform/gtk-wk1/http/tests/security: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Added.
* platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Added.
* platform/gtk-wk2/http: Added.
* platform/gtk-wk2/http/tests: Added.
* platform/gtk-wk2/http/tests/loading: Added.
* platform/gtk-wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Added.
* platform/gtk-wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt: Added.
* platform/gtk-wk2/http/tests/misc: Added.
* platform/gtk-wk2/http/tests/misc/401-alternative-content-expected.txt: Added.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-1: Added.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Added.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-2: Added.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Added.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-4: Added.
* platform/gtk-wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Added.
* platform/gtk-wk2/http/tests/security: Added.
* platform/gtk-wk2/http/tests/security/401-logout: Added.
* platform/gtk-wk2/http/tests/security/401-logout/401-logout-expected.txt: Added.
* platform/gtk-wk2/http/tests/xmlhttprequest: Added.
* platform/gtk-wk2/http/tests/xmlhttprequest/failed-auth-expected.txt: Added.
* platform/gtk-wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt: Added.
* platform/gtk-wk2/js: Added.
* platform/gtk-wk2/js/dom: Added.
* platform/gtk-wk2/js/dom/constructor-length-expected.txt: Added.
* platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt: Added.
* platform/gtk/http/tests/cache: Removed.
* platform/gtk/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Removed.
* platform/gtk/userscripts: Added.
* platform/gtk/userscripts/script-run-at-end-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reduce repetitive EventTarget subclassing.
<https://webkit.org/b/121915>

Reviewed by Antti Koivisto.

Add a EventTargetWithInlineData helper class to EventTarget.h.
It's a simple subclass with an EventTargetData member and FINAL
eventTargetData()/ensureEventTargetData() overrides.

Turns out that this fits almost every use case except Node and
SVGElementInstance.

Inlined most of the FINAL EventTarget overrides since they will
be called on tight pointers by generated bindings code and this
removes the need for virtual dispatch.

Spammed OVERRIDE FINAL as appropriate, we can't make the whole
classes FINAL until bug 121747 is fixed, so added FIXMEs.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Windows] Unreviewed build fix: Add new syntax of function declaration to
Windows export definition file.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening. Moving WK1-specific failure expectations into the WK1-specific TestExpectations.
Also adding expectations for the currently failing tests on WK2.

* platform/gtk-wk1/TestExpectations:
* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=121885.
<rdar://problem/15072332>.

Reviewed by Brent Fulgham.

No new functionality added.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively):
* rendering/RenderLayer.h:
* WebView.cpp:
(WebView::gestureNotify):
(WebView::gesture):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] Switch the 64-bit Release builder to testing layout tests under WK2
https://bugs.webkit.org/show_bug.cgi?id=121256

Reviewed by Martin Robinson.

Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.

* BuildSlaveSupport/build.webkit.org-config/config.json:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156417 268f45cc-cd09-0410-ab3c-d52691b4dbfc