IMHO, the biggest problem with this code is that it's missing a comment, which I said I would address in my reply. As a secondary concern, yes, it could be tighter code. Still, this code is also not just not in the fast path, it's not in ANY path. So less snarky version of your summary from the previous comment is not 100% off. In this case, however, I've already tightened up the code for my next commit.