Fix JavaDoc of synchronization requirements of computeAllScoresWithoutCommit():
- We use the IdentityFetcher so the caller must synchronize on it
- We use the WOT so the caller must synchronize on it
- The function does not need to be synchronized since the caller has to take care of locking the WOT anyway: He has to to preserve locking order between WOT and IdentityFetcher.
- This is related to https://bugs.freenetproject.org/view.php?id=5880
- The following commits on this branch will take care of fixing all callers of this function.
Merge branch 'master' into computeAllScoresWithoutCommit-synchronization
JavaDoc formatting
Fix JavaDoc of beginTrustListImport():
- This is a caller of computeAllScoresWithoutCommit(). Therefore it has to constrain to its synchronization requirements.
- It should also be documented that the callers have to use finishTrustListImport()/abortTrustListImport().
- The following commits will deal with its callers.
Fix JavaDoc of abortTrustListImport(Exception e, LogLevel logLevel):
- This is a caller of computeAllScoresWithoutCommit(). Therefore it has to constrain to its synchronization requirements.
- It should also be documented that the callers have to use beginTrustListImport()
- The following commits will deal with its callers.
Fix JavaDoc of abortTrustListImport(Exception e):
- This is a caller of computeAllScoresWithoutCommit(). Therefore it has to constrain to its synchronization requirements.
- It should also be documented that the callers have to use beginTrustListImport()
- The following commits will deal with its callers.
Actually comment a bit what the functions do
Fix JavaDoc of finishTrustListImport():
- This is a caller of computeAllScoresWithoutCommit(). Therefore it has to constrain to its synchronization requirements.
- It should also be documented that the callers have to use beginTrustListImport()
- The following commits will deal with its callers.
Merge branch 'master' into computeAllScoresWithoutCommit-synchronization
Document beginTrustListImport() synchronization usage
Don't execute abortTrustListImport() unsless one was actually started
Update synchronization requirements documentation
Fix synchronization of deleteOrphanObjects():
- This is a caller of computeAllScoresWithoutCommit(). Therefore it has to constrain to its synchronization requirements.
- The following commits will deal with its callers.
Fix synchronization of verifyAndCorrectStoredScores():
- This is a caller of computeAllScoresWithoutCommit(). Therefore it has to constrain to its synchronization requirements
- Notice that the removed JavaDoc was incorrect with regards to the IntroductionPuzzleStore: computeAllScoresWithoutCommit() does not use it.