I fixed it sorting now works correctly, we were comparing the wrong thing in bubble sort and the char* in swap needed to be passed by reference, also the inner loop needed to be set to end at CHAR_MAX-1 since we are comparing j with j+1 to avoid an out of bounds error