fix missing upvalue