finished pop up dialog in popup branch