Luke,

I'm not sure I would agree with using get_safe here -- if these are
supposed to be required values, then we want it to fail with an error if
they are skipped.  Having a default value like this to fall back to
silently hides the problem.  Lat and lon are not just markers of where the
data is coming from, they are involved in the calculation directly.

Jonathan


On Wed, Mar 13, 2013 at 8:39 AM, Luke Campbell <notifications@github.com>wrote:

> In ion/processes/data/transforms/ctdbp/ctdbp_L2_density.py:
>
> > @@ -30,9 +32,14 @@ def on_start(self):
> >                               "using a special keyword (ex: density)")
> >          self.dens_stream_id = self.CFG.process.publish_streams.density
> >
> > +        lat = self.CFG.lat
> > +        lon = self.CFG.lon
>
> since lat and lon are specific to the proces please set them under
> CFG.process.lat and CFG.process.lon also when reading variables from a
> DotDict you should use get_safe
>
> lat = self.CFG.get_safe('process.lat', 0)lon = self.CFG.get_safe('process.lon', 0)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ooici/coi-services/pull/688/files#r3356254>
> .
>