Confused now. Can you walk me through why those tests are failing? We
should also comment as to why this conditional is needed as my original
question was due to not knowing what the flag was for (and frankly still
not 100%)


On Wed, Jul 10, 2013 at 1:09 PM, Ryan Eastridge <notifications@github.com>wrote:

> In src/thorax.js:
>
> >      this.children[view.cid] = view;
> > -    if (!view.parent) {
> > -      view.parent = this;
> > +    if (view.parent && view.parent !== this && !view._helperOptions) {
>
> Instinct was right here, these two fail: phantom: 1) helper-view should
> nest helper view instances: phantom: 2) collection helper nested collection
> helper: Good to merge as is?
> … <#13fc9caab77b36ef_>
> On Wed, Jul 10, 2013 at 9:44 AM, Kevin Decker <notifications@github.com>wrote:
> In src/thorax.js: > this.children[view.cid] = view; > - if (!view.parent) {
> > - view.parent = this; > + if (view.parent && view.parent !== this &&
> !view._helperOptions) { I think making the behavior conditional could lead
> to some wierd behavior where if you somehow managed to access a helper view
> instance and move it to another view you would have a slip parent situation
> where the view might be destroyed as unexpected times. Unless there was a
> specific error case that this was handling I think we should have common
> behavior across the board, even if the case above is edge/probably
> shouldn't be formally supported. — Reply to this email directly or view it
> on GitHub<https://github.com/walmartlabs/thorax/pull/197/files#r5119838>
> .
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/walmartlabs/thorax/pull/197/files#r5122210>
> .
>