gentle reminder:


Could I have you opinion on my latest proposal:


I'm not sure it makes sense to support files w/o 
extensions; as far as I can tell, they are being ignored when the 
library is scanned.

So although it can be done, I don't think tag reader will encounter files w/o extension.


Well, maybe an internet stream, but we probably don't want to trust that stream to mess with the volume button.

            
          
Thanks,
Frederik
Date: Thu, 7 Nov 2013 11:08:19 -0800
From: notifications@github.com
To: xbmc@noreply.github.com
CC: frederikslos@hotmail.com
Subject: Re: [xbmc] fix: Use replaygain tags for .m4a type family files too, closes Ticket #13948  (#3587)

In xbmc/cores/paplayer/DVDPlayerCodec.cpp:

> @@ -156,6 +157,10 @@ bool DVDPlayerCodec::Init(const CStdString &strFile, unsigned int filecache)
>      return false;
>    }
>  
> +  //  Extract ReplayGain info
> +  CTagLoaderTagLib tagLoaderTagLib;
> +  tagLoaderTagLib.Load(strFile, m_tag, "mp4");
> +

The difference is that we can instantiate using a mimetype (see CodecFactory::CreateCodecDemux) in which case we do have a little more detail that we can give the tag reader in case we have no extension at all.


—
Reply to this email directly or view it on GitHub.