Hi Justin,

(Couldn't find your comments in github so i'm replying via email...)
I don't get it. I do the same thing for Contrast adjuster. Simple value binding of a checkbox with a model value. 
https://github.com/chrispetsos/prefsEditors/blob/master/src/shared/adjusters/js/ContrastAdjuster.js
The only difference is that "Contrast" participates in the schema passed to the store, while the "increase size extras enabled" model value is locally in the adjuster's model.
https://github.com/chrispetsos/prefsEditors/blob/master/src/shared/adjusters/js/IncreaseSizeAdjuster.js#L139
In "magnifier follows" the use of the expander is due to the repetition right? Why would i need it here?

Date: Fri, 18 Oct 2013 11:42:31 -0700
From: notifications@github.com
To: prefsEditors@noreply.github.com
CC: chrispetsos@msn.com
Subject: Re: [prefsEditors] GPII-187, GPII-188, GPII-225, GPII-227 contributions (#7)

In src/pmt/js/PMT.js:

> +                    expander: {
> +                        func: "gpii.uiOptions.pmt.lookupMsg",
> +                        args: ["{uiOptionsLoader}.msgBundle", "less"]
> +                    }
> +                }
> +            }
> +        }
> +    });
> +
> +    gpii.uiOptions.pmt.toggleIncreaseSizeExtraAdjusters = function (elm, showEvent, hideEvent) {
> +        if (elm.is(":visible")) {
> +            hideEvent();
> +        } else {
> +            showEvent();
> +        }
> +    };

I've made some additional comments further up. As for comments here about requestChange, the model should actually be updated automatically. However, it looks like the prototree is not correct. You have simple valuebinding which probably is trying to set the text of the element to the model value. Although since it's an input probably nothing is happening. What you really want to do is something similar to what's used for the magnifier follows adjuster. You can also look at the documentation http://wiki.fluidproject.org/display/docs/Renderer+Component+Tree+Expanders#RendererComponentTreeExpanders-SelectionToInputsExpander


—
Reply to this email directly or view it on GitHub.