[AX] Generate toAccessibilityTableRow|Column|Cell to detect bad type casts
https://bugs.webkit.org/show_bug.cgi?id=123984

Reviewed by Mario Sanchez Prada.

As a step to let static_cast<> use TYPE_CASTS_BASE, AccessibilityTableRow|Column|Cell use
ACCESSIBILITY_OBJECT_TYPE_CASTS which can support more helper functions rather than manual
static_cast<>. This change will help to detect bad type casts further.

No new tests, no behavior changes.

* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addTableCellChild):
(WebCore::AccessibilityARIAGrid::addChildren):
* accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cellForColumnAndRow):
* accessibility/AccessibilityTableCell.h:
* accessibility/AccessibilityTableColumn.h:
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::headerObject):
* accessibility/AccessibilityTableRow.h:
* accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(cellAtIndex):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper tableCellParent]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
RenderSVGResource helpers should take RenderStyle by const reference.
<https://webkit.org/b/124029>

Take const RenderStyle& instead of RenderStyle* in a few more places
so we can get rid of some ampersands and assertions.

Reviewed by Anders Carlsson.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Update an out-dated ASSERT in IconDatabase code.
<rdar://problem/15171118> and https://bugs.webkit.org/show_bug.cgi?id=124030.

Reviewed by Andreas Kling.

With the asynchronous interfaces that have been added and the support for WK2 that has been added,
this ASSERT can incorrectly fire if an icon is asked for before database cleanup is allowed.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL): Update an invalid ASSERT.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Layout tests with vertical texts need to be rebaselined
https://bugs.webkit.org/show_bug.cgi?id=123985

Unreviewed, EFL port needs to do rebaseline since r158848.


* platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Removed.
* platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
* platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Removed.
* platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
* platform/efl/TestExpectations:
* platform/efl/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/efl/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
* platform/efl/fast/block/lineboxcontain/block-with-ideographs-expected.txt:
* platform/efl/fast/dynamic/text-combine-expected.txt:
* platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
* platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
* platform/efl/fast/ruby/base-shorter-than-text-expected.txt:
* platform/efl/fast/text/decorations-with-text-combine-expected.txt:
* platform/efl/fast/text/emphasis-combined-text-expected.txt:
* platform/efl/fast/text/emphasis-vertical-expected.txt:
* platform/efl/fast/text/international/text-combine-image-test-expected.txt: Added.
* platform/efl/fast/text/international/text-spliced-font-expected.txt:
* platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
* platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Added.
* platform/efl/fast/text/orientation-sideways-expected.txt:
* platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
* platform/efl/fast/writing-mode/border-vertical-lr-expected.txt:
* platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
* platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
* platform/efl/fast/writing-mode/fallback-orientation-expected.txt:
* platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt:
* platform/efl/fast/writing-mode/japanese-lr-text-expected.txt:
* platform/efl/fast/writing-mode/japanese-rl-selection-expected.txt:
* platform/efl/fast/writing-mode/japanese-rl-text-expected.txt:
* platform/efl/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/efl/fast/writing-mode/text-orientation-basic-expected.txt:
* platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
* platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.txt:
* platform/efl/fast/writing-mode/vertical-font-fallback-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Enhance SQL journal_mode setting code to be less likely to log an error.
<rdar://problem/15418577> and https://bugs.webkit.org/show_bug.cgi?id=124018

Reviewed by Anders Carlsson.

Even though the docs says SQLITE_ROW will always be returned, apparently SQLITE_OK is sometimes returned.
Change the code to handle that.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open): Save the statement result value, and accept SQLITE_OK as a non-error condition.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158906 268f45cc-cd09-0410-ab3c-d52691b4dbfc