It can go either way here but I'm fine to resolve here, since there is no difference in behavior. this method was not async before hence there are no expectation how it behaves. The only place this is called from is DocumentCommandHandlers and that is handling a rected promise by propagating to the project manager which will open _lastSelected, I agree that it gets a bit complicated there, so it's better to resolve.