Yes, sir. I agree with this.

Andrea D'Amico


On Wed, Oct 30, 2013 at 10:47 AM, Akshat Pradhan
<notifications@github.com>wrote:

> In config/initializers/omniauth.rb:
>
> > @@ -1,3 +1,3 @@
> >  Rails.application.config.middleware.use OmniAuth::Builder do
> > -  provider :twitter, ENV['OMNIAUTH_PROVIDER_KEY'], ENV['OMNIAUTH_PROVIDER_SECRET']
> > +  provider :dwolla, ENV['DWOLLA_KEY'], ENV['DWOLLA_SECRET'], :scope => 'accountinfofull|send|request', :provider_ignores_state => true
>
> code review: I'm tempted to think DWOLLA_KEY should just stay
> OMNIAUTH_PROVIDER_KEY. Its no biggies because its all just a variable, but
> I noticed in omniauth.rb the name was also OMNIAUTH_PROVIDER_KEY. Code
> consistency I guess.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/akshatpradhan/lending_round/pull/5/files#r7306320>
> .
>