Glad to help!


On Thu, Sep 5, 2013 at 9:33 AM, nepsilon <notifications@github.com> wrote:

> In chapters/ajax/ajax_request_without_jquery.md:
>
> > @@ -47,7 +47,7 @@ loadDataFromServer = ->
> >
> >    req.addEventListener 'readystatechange', ->
> >      if req.readyState is 4                        # ReadyState Compelte
> > -      if req.status is 200 or req.status is 304   # Success result codes
> > +      if req.status in [200, 304]   # Success result codes
>
> Good idea. I just commited this change.
> … <#140ee54a1c0a3a35_>
> -- Julien Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
> On Thursday, September 5, 2013 at 9:17 PM, James Holder wrote: In
> chapters/ajax/ajax_request_without_jquery.md (
> http://ajax_request_without_jquery.md): > @@ -47,7 +47,7 @@
> loadDataFromServer = -> > > req.addEventListener 'readystatechange', -> >
> if req.readyState is 4 # ReadyState Compelte > - if req.status is 200 or
> req.status is 304 # Success result codes > + if req.status in [200, 304] #
> Success result codes Good change. Can you put the array in a
> semantically-meaningful variable? For example successResultCodes = [200,
> 304] if req.status in successResultsCodes Then it reads even more
> naturally. :) — Reply to this email directly or view it on GitHub (
> https://github.com/coffeescript-cookbook/coffeescript-cookbook.github.com/pull/89/files#r6180754).
>
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/coffeescript-cookbook/coffeescript-cookbook.github.com/pull/89/files#r6181142>
> .
>