Isn't a default already set trougakoss?

From what I can see the default is defined in the function signature.


On Mon, Jun 17, 2013 at 9:35 AM, trougakoss <notifications@github.com>wrote:

> In application/controllers/admin/remotecontrol.php:
>
> > +     */
> > +    public function get_survey_fieldmap($sSessionKey, $iSurveyID, $sStyle='full', $sLanguageCode=null)
> > +    {
> > +        if (!$this->_checkSessionKey($sSessionKey))
> > +        {
> > +            return array('status' => 'Invalid session key');
> > +        }
> > +
> > +        if (!tableExists('{{survey_' . $iSurveyID . '}}'))
> > +        {
> > +            return array('status' => 'No Data');
> > +        }
> > +
> > +        if (!in_array($sStyle, array('short','full')))
> > +        {
> > +            return array('status' => 'Invalid Period');
>
> Maybe the error status should be 'Invalid Style' or maybe we could set by
> default $sStyle='full'
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/LimeSurvey/LimeSurvey/pull/86/files#r4719024>
> .
>