Incorporated now.


2013/3/6 juliusv <notifications@github.com>

> In storage/metric/tiered.go:
>
> > +}
> > +
> > +// Provides a unified means for batch appending values into the datastore along
> > +// with querying for values in an efficient way.
> > +type Storage interface {
> > +	// Enqueues a Sample for storage.
> > +	AppendSample(model.Sample) error
> > +	// Enqueus a ViewRequestBuilder for materialization, subject to a timeout.
> > +	MakeView(request ViewRequestBuilder, timeout time.Duration) (View, error)
> > +	// Starts serving requests.
> > +	Serve()
> > +	// Stops the storage subsystem, flushing all pending operations.
> > +	Drain()
> > +}
> > +
> > +func NewTieredStorage(appendToMemoryQueueDepth, appendToDiskQueueDepth, viewQueueDepth uint, flushMemoryInterval, writeMemoryInterval, memoryTTL time.Duration) Storage {
>
> I'm looking at an almost-deadlock right now, in which I'm not sure what
> parts of the scraping/storage system are stuck (very seldomly, I still see
> a scrape arriving at the metrics endpoint). I just realized it would be
> great to expose metrics about these queue lengths (queue size vs. fillup).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/prometheus/prometheus/pull/84/files#r3273173>
> .
>