Agreed removed the changes.. But is it okay for you too, remove authenticator information from friendlyName?

 

From: John Lyle [mailto:notifications@github.com] 
Sent: 07 June 2013 09:18
To: webinos/webinos-pzh
Cc: Habib Virji
Subject: Re: [webinos-pzh] Synchronization Manager and Id changes (#9)

 

In lib/pzh_tlsSessionHandling.js:

> @@ -369,7 +360,7 @@ var Pzh = function () {
>              }
>              self.config.userData.authenticator = user.from;
>              self.config.userData.identifier = user.identifier;
> -            self.config.metaData.friendlyName = self.config.userData.name +" ("+ self.config.userData.authenticator + ")";
> +            self.config.metaData.friendlyName = self.config.userData.name;// +"_"+ self.config.userData.authenticator  ;

I suggest, as a rule, it's a good idea not to include commented code. The only reason for doing so (in my head) is if it's a temporary disabling of functionality that is likely to come back soon in the future. And even then it's not a great idea.

—
Reply to this email directly or view it on GitHub <https://github.com/webinos/webinos-pzh/pull/9/files#r4584624> .  <https://github.com/notifications/beacon/XUg7godVN2O0jV1-5T0xOwPN2Z_Pg9PhcO5-3YS0IMAnJnaBLlM0UZiad98jC7fM.gif>