You are right. It is completely unnecessary.


On 23 December 2013 17:38, Marcel Bokhorst <notifications@github.com> wrote:

> In src/biz/bokhorst/xprivacy/ApplicationInfoEx.java:
>
> > @@ -187,7 +193,14 @@ public String toString() {
> >
> >  	@Override
> >  	public int compareTo(ApplicationInfoEx other) {
> > -		return TextUtils.join(", ", getApplicationName()).compareToIgnoreCase(
> > +		if (mContext == null)
>
> Why is this needed?
>
> Storing a context for later use is not a good idea in general.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/M66B/XPrivacy/pull/1004/files#r8530875>
> .
>