improve update_roles method. red/green/refactor -> green