moved all these params to controller