add doc, use constant