I was going got import some of these tests:
https://github.com/jorendorff/js-loaders/blob/master/test/Module-constructor-nonobject.js

They all use `new Module`.

Therefore I do not see the point in renaming Module.

Otherwise LGTM


On Fri, Dec 20, 2013 at 2:26 PM, johnjbarton <notifications@github.com>wrote:

> In src/runtime/modules.js:
>
> >    };
> >
> >    var moduleInstances = Object.create(null);
> >
> >    var liveModuleSentinel = {};
> >
> > -  function Module(obj, isLive = undefined) {
>
> Neither is the function Module() observable, except through the
> constructor name property which differs from the spec.
>
> Is this the main issue you have with this patch? I'm fine with one
> ambiguous name if we can fix the rest.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/google/traceur-compiler/pull/580/files#r8508177>
> .
>



-- 
erik