promotion controller fixes