On Nov 25, 2013, at 7:10 AM, Thomas Tempelmann <notifications@github.com> wrote:

> In macoslib/CoreFoundation/CFBoolean.rbbas:
> 
> > -		  return b
> > +		  return Get(true)
> > +		End Function
> > +	#tag EndMethod
> > +
> > +	#tag Method, Flags = &h21
> > +		Private Shared Function MakeCache() As Dictionary
> > +		  #if targetMacOS
> > +		    dim d as new Dictionary(false : "kCFBooleanFalse", true : "kCFBooleanTrue")
> > +		    
> > +		    for each key as Boolean in d.Keys
> > +		      dim p as Ptr = CoreFoundation.Bundle.DataPointerNotRetained(d.Value(key))
> > +		      if p <> nil then
> > +		        p = p.Ptr(0)
> > +		      else
> > +		        //this case should not happen.
> 
> I recommend to place at least a "break" into such places, if you do not want to add code to raise an exc
> 
> —
> Reply to this email directly or view it on GitHub.
> 


My preference would be to replace the comment with an assertion that raises an exception on failure.