corrections: Add correction for privileges

Signed-off-by: Niels Thykier <niels@thykier.net>
update outdated-autotools-helper-file description to match code

Signed-off-by: Niels Thykier <niels@thykier.net>
L::Tag::Info: Fix typo description of exp. tags

Signed-off-by: Niels Thykier <niels@thykier.net>
spelling: Add correction for application and access

From #703829 and #703830.

Signed-off-by: Niels Thykier <niels@thykier.net>
c/standards-versions: Bump ANCIENT_DATE to 20th of April

Signed-off-by: Niels Thykier <niels@thykier.net>
man/lintian.pod.in: Document --pedantic is -L +=pedantic

Signed-off-by: Niels Thykier <niels@thykier.net>
L::Tag::Info: Improve error message on bad severity/certain

Signed-off-by: Niels Thykier <niels@thykier.net>
c/cpy-right: Avoid F-P tag with the MPL-2.0 license

Signed-off-by: Niels Thykier <niels@thykier.net>
lintian: Add --no-display-experimental command line option

Signed-off-by: Niels Thykier <niels@thykier.net>
WritingChecks: Remove copy/waste block and fix minor issues

Signed-off-by: Niels Thykier <niels@thykier.net>
d/changelog: Fix typo of certainty

Signed-off-by: Niels Thykier <niels@thykier.net>
L::Util: Introduce "{,l,r}strip" ...

... to replace uses of s/^\s++//; or/and s/\s++$//;.  In void context
they modify their input inplace and in other contexts they copy the
input.  Thus they can replace the "chomp" like:

  while ( my $line = <>) {     while (<>) {
     strip ($line);               strip;
     # do something ...           # do something...
  }                            }

For cases where the original input might be useful, they can also
return a copy:

  while ( my $orig = <>) {
     my $stripped = strip ($orig);
  }

Signed-off-by: Niels Thykier <niels@thykier.net>
*: Replace ad-hoc regexes with {,l,r}strip

Signed-off-by: Niels Thykier <niels@thykier.net>
lib: Revise some of the SYNOPSIS examples

Signed-off-by: Niels Thykier <niels@thykier.net>
lib: Replace use of "base" with "parent"

From the documentation of "base":

"""
Unless you are using the fields pragma, consider this module
discouraged in favor of the lighter-weight parent.
"""

Signed-off-by: Niels Thykier <niels@thykier.net>
Fix "useless interpolation" warnings in the code base

... and (where spotted) fixed a couple of error messages.

Signed-off-by: Niels Thykier <niels@thykier.net>
t: Enable perl critic test by default (with reduced policy)

Instead of having a strict policy we never enforce, have a small
policy we currently follow and can enforce.

Signed-off-by: Niels Thykier <niels@thykier.net>
.perlcriticrc: Reinstate critic policies already followed

Signed-off-by: Niels Thykier <niels@thykier.net>
Enable and comply with perlcritic UnusedVariables policy

... also add UseStrict and UseWarnings, which we already comply with
as well (though UseStrict sound like a duplicate of our strict.t
check).

Signed-off-by: Niels Thykier <niels@thykier.net>
checks/*: Remove unused capture groups

Enable the UnusedCapture policy and fix all remaining "violations".

Some "fixes" include having to store the capture in a local variable
immediately to avoid false-positives.

Signed-off-by: Niels Thykier <niels@thykier.net>