Right now for Cinder it does not matter as much, as both the original code
and the refactored stuff only took action on disks if the volume group it
uses as backing store does not exist.


On Wed, Jun 5, 2013 at 1:08 AM, Vincent Untz <notifications@github.com>wrote:

> In chef/cookbooks/cinder/recipes/volume.rb:
>
> >    end
> > -  max_fsize = ((`df -Pk #{encl_dir}`.split("\n")[1].split(" ")[3].to_i * 1024) * 0.90).to_i rescue 0
> > -  fsize = max_fsize if fsize > max_fsize
> > -
> > -  bash "create local volume file" do
> > -    code "truncate -s #{fsize} #{fname}"
> > -    not_if do
> > -      File.exists?(fname)
> > +  unclaimed_disks = BarclampLibrary::Barclamp::Inventory::Disk.unclaimed(node)
>
> After the discussion in the barclamp-swift review, I think we need the
> same behavior here where we don't have just unclaimed disks, but unclaimed
> disks + disks owned by cinder in this list.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/crowbar/barclamp-cinder/pull/25/files#r4539507>
> .
>