Yeah, that sounds right to me.


On Mon, Aug 5, 2013 at 5:53 PM, seberg <notifications@github.com> wrote:

> In numpy/core/src/umath/ufunc_object.c:
>
> > +         * puts result in buffer.
> > +         */
> > +        do {
> > +            innerloop(buffer_dataptr, count, stride, innerloopdata);
> > +        } while (iternext(iter_buffer));
> > +
> > +        PyArray_MapIterNext(iter);
> > +        if (iter2 != NULL) {
> > +            PyArray_ITER_NEXT(iter2);
> > +        }
> > +
> > +        i--;
> > +    }
> > +
> > +    if (!needs_api) {
> > +        NPY_END_THREADS;
>
> I guess we can live with object_array += something leaving object_arrayin an inconsistent state upon an error? The same will be the case for
> ufunc.at(object_array, indices, something). Just thought there was an API
> question here, but += also just stops when the first error occured, so I
> think we can copy that behaviour, or does anyone disagree?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/numpy/numpy/pull/2821/files#r5583608>
> .
>