add in generic attributes
add in generic attributes