fixed harmless dead store warnings from clang static analyzer

Change-Id: Ib93a15df2834cc8c6aab0e3bd0893e56de88fb93
fixed dead store warning by adding what is probably a missing 'break'

Change-Id: Ifc4a025f09094e69859b89e92f1ede5d548cb9fc
fixed dead store warning

fixed by correcting what looks like accidental non-use of a variable (due to copy-paste?)

Change-Id: I477d4a3ae13de8a575a005d5606a284ccbed15b5
fixed null deref warning

fixed by bailing out instead of just calling vtkErrorMacro upon memory allocation failure.  Failure unlikely to ever happen anyway.

Change-Id: I479e47c61de33440a69cb42a0be619e150453c3e
fixed null deref warning with more careful error logging

Change-Id: I546a91c29298958528a74a2c24c04c00407e13d1
fixed dead store by matching store and use in 'ifndef NDEBUG'

Change-Id: Icc995fb795d879ae468f54dbae39cb1d6ed95c11
use ignored return value in output log

Change-Id: Ie7b17bebe300bbcc2d0e0406b7f9e17c87eaa6b1
fix warning by eliminating redundant loop termination variable

Change-Id: I9032d6cb876e2df5874737bf1a579722de27d2cb
fixed dead store warning by removing the dead store

(some chance here these values should in fact be used somehow!)

Change-Id: I06e43acdeb596d71693fd45d71eea0e2b2eb7092
fixed redundant store warning by declaring & assigning together

Change-Id: I957f1212e6fccaec8205e0a395507c465b4eaf47
fixed dead store warnings

fixed by removing the dead stores (I've assumed the method calls have no weird side effects)

Change-Id: I163de6df4e290ce7d98c6ef20e3518a5dcc21441
fixed null deref warning in ctor

fixed by initializing a member variable to ft_encoding_none, which seems reasonable (and can be no worse than dereferencing null!)

Change-Id: I583c87c288f5750522a41e86f48b157a41ea8bb8
fixed null deref warning

just removed the null deref, it looks like botched error handling, and is redundant because the thing it's trying to set to null was set to null previously.

Change-Id: I3da3a7061940f1ae08c4384276bfdbb0d08feab3
fixed dead store warning

fixed by using the dead store as part of the error checking

Change-Id: I52afaaaf6eb9acb30a12607a8c86c4a0093d5423
fixed dead store warning by removing dead store

Change-Id: If529be09a0d4325b6429c2678055eb4267a07b8e
moved some declarations together with initial assignments.

Doesn't fix any warning or problem, just saw these while I was addressing some nearby clang analyzer warnings.

Change-Id: Ic4638fb4b865a52cdca52611039a5fde9cb5be8f
Restored VTK_REQUIRED_OBJCXX_FLAGS in main CMakeLists.txt

It seems to have been accidentally removed in the massive modularization commit (0c1471f1).  Removed check for 10.4 SDK since VTK6 now requires 10.5.  VTK_REQUIRED_OBJCXX_FLAGS is set to "-fobjc-gc" so that VTK libraries can be linked into either GC or non-GC processes.

Change-Id: Ifaeb2b4299b2aa4b92fd32bf9abdd5ad96b42ab7
Restored VTK_REQUIRED_OBJCXX_FLAGS in main CMakeLists.txt

It seems to have been accidentally removed in the massive modularization commit (0c1471f1).  Removed check for 10.4 SDK since VTK6 now requires 10.5.  VTK_REQUIRED_OBJCXX_FLAGS is set to "-fobjc-gc" so that VTK libraries can be linked into either GC or non-GC processes.

Change-Id: I33a89c768772f9c003b587e731acfff8413210e6
fixed a couple more -Wdocumentation warnings.

Changes to comments only.

Change-Id: I3754270c9f5b309f1f609113768db169ed12b7ca
COMP: Adjust timeouts for long running tests

Some tests require more than the 21 seconds allocated to cdash@home
gerrit machines. The timeout was adjusted to accommodate the maximum
run time over all vtk dashboard machines.

Change-Id: Ibdbe17427bb7cb43f1e9d81ac0fe904b097f4f50