ah ok got it


On Thu, Jun 20, 2013 at 11:23 AM, P. Oscar Boykin
<notifications@github.com>wrote:

> In algebird-core/src/main/scala/com/twitter/algebird/MinHasher.scala:
>
> > @@ -99,36 +125,34 @@ abstract class MinHasher[H](targetThreshold : Double, maxBytes : Int)(implicit n
> >    /** useful for understanding the effects of numBands and numRows */
> >    def probabilityOfInclusion(sim : Double) = 1.0 - math.pow(1.0 - math.pow(sim, numRows), numBands)
> >
> > -  /** numerically solve the inverse of estimatedThreshold, given numBands*numRows */
> > -  def pickBands(threshold : Double, hashes : Int) = {
> > -    val target = hashes * -1 * math.log(threshold)
> > -    var bands = 1
> > -    while(bands * math.log(bands) < target)
> > -      bands += 1
> > -    bands
> > -  }
> > -
> >    /** Maximum value the hash can take on (not 2*hashSize because of signed types) */
> >    def maxHash : H
>
> I was just saying if we implemented #166<https://github.com/twitter/algebird/issues/166>we could use that typeclass here.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/twitter/algebird/pull/144/files#r4799202>
> .
>