Remove improper NotFound except block in list servers

Added a couple tests to verify that NotFound was actually
never raised when no results are returned from list servers
or list servers details, and then removed the except blocks
from the controller.

Change-Id: I36856066b9e4c4e3f7b85ddf8facb35204034838
fixes: lp bug #1089385
Check for image_meta in libvirt.driver.spawn

This adds check that image_meta exists in libvirt driver
spawn method. In case it doesn't the image shouldn't be
created.

part of libvirt driver support for blueprint rebuild-for-ha

DocImpact

Change-Id: I097c7cbfde96bcb21b4f06af4e5bac00440849c2
Co-authored-by: Oshrit Feder <oshritf@il.ibm.com>
Remove unused imports

And one unused variable

Change-Id: I81edaf7ddedd7723c2601b30951ca82bd2cd5256
Remove session.flush() and session.query() monkey patching

Use custom Session class to avoid monkey patching of SqlAlchemy
Session instance.

blueprint db-session-cleanup

Change-Id: I7d40c20e585782403556f3587141805c197bfa64
Raise BadRequest when updating 'personality'

Updating booted server instance through server PUT API call with
'personality' property set is not returning 'Bad Request', although the
property is not allowed to be updated once the instance is booted.

This fixes the described problem.

Fixes bug #1032546

Change-Id: Ia086f5ea5176640a9916a3ba42c79d4d5944ce76
Adds os-volume_attachments 'volume_id' validation

If you POST to os-volume_attachments but give the name of the volume
instead of a UUID, it returns a 404 error; this is invalid HTTP.
404 means that the Request-URI has not been found. In fact, the
Request-URI has been found, but a child attribute has been incorrectly
specified. Some other error could be used.

This fixes the problem by returning 'BadRequest' in place of 'NotFound'.
The 'volumeId' is checked to be a valid UUID string before moving
further.

Fixes bug #1062494

Change-Id: Icc5dbc7ac94051514709997457cafb16e870bea9
Add unit test for too long metadata for server rebuild action

This fixes bug: 1088686
Partially implements blueprint nova-v2-api-audit

Change-Id: Ibf2b468cb95e0b1be9f47c0ff01ae55ce56d421d
Improve baremetal driver error handling

Several improvements to baremetal driver are implemented in this patch.
There is now significantly more error handling during spawn().

It also includes an addition to nova/tests/utils.py to provide
additional sample information from get_test_network_info().

blueprint general-bare-metal-provisioning-framework

Change-Id: I65d93051d7fcfd79f4d24d4ddb62fb1a55bee646
Merge "Adds os-volume_attachments 'volume_id' validation"
Merge "Add unit test for too long metadata for server rebuild action"
Merge "Raise BadRequest when updating 'personality'"
Merge "Remove improper NotFound except block in list servers"
Merge "Remove session.flush() and session.query() monkey patching"
Merge "Check for image_meta in libvirt.driver.spawn"
Merge "Remove unused imports"
Merge "Improve baremetal driver error handling"