Hi Tom,

Didn't have access to the internet for the week end. I will try to answer
to all your questions.

1/ in MainForm.cs there is a lot of deleted code. I placed the code
in Programs.cs to reduce code duplication : Parse/build/eval of grammar is
done only in Program now and Mainform.cs beiing the view, it should not
contains any business methods.

2/ Sorry for the spaces, I done a code auto-formatting at one time and even
if i tried to go back with the same number of spaces, git report them :(

3/ //var args = Environment.GetCommandLineArgs();
Sure you can remove it, I wasn't sure to reproduce the same behavior of
this command before i changed Main() 's signature, so I commented it for
reference "just in case". I just forget to remove it.

4/ I thought it was for the best... well apparently not. will do as you say
next time :)

5/ Yes ProgramTester is there to help test Program.cs. I should have filled
the <summary>

I think I addressed all your mails. Thank you for the reviews and feedbacks.
If any questions, fell free to ask.


Jissai



2013/3/8 Tom Spilman <notifications@github.com>

> In TinyPG.UnitTests/ProgramTester.cs:
>
> > @@ -0,0 +1,79 @@
> > +﻿using System;
> > +using System.Text;
> > +using System.Collections.Generic;
> > +using System.Linq;
> > +using Microsoft.VisualStudio.TestTools.UnitTesting;
> > +using TinyPG.Compiler;
> > +
> > +namespace TinyPG.UnitTests
> > +{
> > +    /// <summary>
> > +    /// Summary description for ProgramTester
> > +    /// </summary>
> > +    [TestClass]
> > +    public class ProgramTester
>
> What is this class for?
>
> The <summary> is basically empty.
>
> Is it just a unit test for your Program class changes? Or is it more than
> that?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/SickheadGames/TinyPG/pull/9/files#r3301515>
> .
>