add doc
change @val to @value