do i need to commit?