Work-around race in AMQ scheduler test giving more room for rounding

It appears to me that the ActiveMQ scheduler implementation will round delays
off to the second-tick. For this reason its possible that results may differ
+/- 1 second dependending on their exact start time in milliseconds from the
second. This change gives more room for this 'jitter'.

Also, upon failures the bounded-drain-into-vec! was blocking forever, as all
messages had already been flushed. This replaces that call with the
timed-drain-into-vec! call which times out. This should remove the main
annoyance of this bug, which is that the tests fail and then block forever
in Jenkins.

Signed-off-by: Ken Barber <ken@bob.sh>
Merge pull request #392 from kbarber/ticket/master/failed-mq-test-blocking

Work-around race in AMQ scheduler test giving more room for rounding
Deprecate Postgresql versions older then 8.4

This patch adds a deprecation warning at PuppetDB startup if the user is using
a version of PostgreSQL older than 8.4.

Signed-off-by: Ken Barber <ken@bob.sh>
Clean up comments re: indirector voodoo

A while back, the utility module defined in `utils/puppetdb.rb`
was pretty tightly coupled with the implementation details of the
Puppet indirector class heirarchy, and the module could (mostly)
only be used as a mix-in on an indirector terminus.  Since then
it's been made to be a bit more general purpose so that it could
be used in other places as well (e.g. report processor).  However,
some of the comments in the code that were meant to explain the
coupling with the indirector were not updated when those changes
were made.  This commit simply removes the old obsolete comments.
Merge pull request #393 from cprice-puppet/maint/master/clean-up-comments-in-rb-utils

Clean up comments re: indirector voodoo
Merge pull request #390 from kbarber/ticket/master/postgresql-8x-deprecation

DONT MERGE YET: Deprecate Postgresql versions older then 8.4
Update changelog for 1.1.0rc1 release
Merge pull request #396 from nicklewis/changelog-1.1.0rc1

Update changelog for 1.1.0rc1 release
Fix DB deprecation warnings when using HSQLDB

In the case of a non-existent database (for instance, during the first
run), we were opening a connection to retrieve the database info for the
deprecation warning, and then closing the connection without creating
anything. This seems to confuse the DB for reasons that aren't exactly
clear. When we then open another connection to migrate, it hangs.

Now the warn-on-db-deprecation! function expects to be called within an
open connection, rather than taking the db as a parameter and opening
the connection itself. This is more consistent with other functions like
it, and also lets us use the same connection for warn-on-db-deprecation!
and migrate!, which means there will always be something in the database
hwne we close our first connection.
Merge pull request #397 from nicklewis/deprecations-with-hsqldb

Fix DB deprecation warnings when using HSQLDB
[packaging] Fix rpm rc versioning

Currently if a tag is formatted in the standard RC format for PL, e.g. appended with '-rcX', the rpm versioning will create a file with an extra '.' in it between version and release, e.g. 'puppetdb-1.1.0.-0.1rc1.el5.src.rpm'. This commit chops the dot from rpm.

Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
Add override to rpm builds for building RCs

Currently, rpm acceptance packaging fails because the automation in the
yum.puppetlabs.com repo checks to ensure an RC version isn't getting shipped
into production unless we pass an OVERRIDE flag. For puppetdb's purposes, this
is what we want, so this patch adds the OVERRIDE flag.

Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
Merge pull request #398 from MosesMendoza/maint/master/fix_rc_rpm_version

[packaging] Fix rpm rc versioning
Rework debian, rpm versioning

This commit sanifies the rpm versioning to be a little more tactful in its
removal of the trailing dot from a version. Second, this commit modifies the
debian version to address an issue where an rc tag resulted in a dash followed
by a dot in the version.

Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
Merge pull request #400 from MosesMendoza/maint/master/fix_rc_rpm_version

Rework debian, rpm versioning
Correctly determine package versions for RCs in acceptance tests

This wasn't taking into account the case of RCs, which need to have the
"rc1" bit put into a particular place in the version.
Merge pull request #401 from nicklewis/correctly-munge-rc-versions

Correctly determine package versions for RCs in acceptance tests
Fix dot-dash in pe version string on debian

Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
We added directories to incoming, cp -r to move to pending

Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
Create pending directory in rpm packaging before scping to it