save necessary config files in finish_install()

Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=988986
Signed-off-by: Joey Boggs <jboggs@redhat.com>
Change-Id: I3e625c68c639f204093c5e9bf70fdb26ccb5ac25
Stop crashing the plugin page by optimistically parsing files

Check whether or not we can actually split on colons for the files
we find instead of trying to do so and crashing so we're not
dependent on edit-node writing metadata for the plugin page
to work.

Change-Id: Ieaf009e86b50e2a83d401f6a4dc6a2cb6c6a2e60
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988982
Signed-off-by: Ryan Barry <rbarry@redhat.com>
system: Fix which()

abspath was used instead of isabs, this broke the logic.

Change-Id: Ida05d44b057056ffbd6300ab4393e143a0ba79b3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=991408
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
network: Use "prefix length" for IPv6

Previously the term "Netmask" was used incorrectly for the IPv6
prefix length. The name is now corrected and additionally only an
integer is allowed as the prefix length.

Change-Id: I18e7829e7c9e4b265822d02aa86c34f8fda41519
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=981168
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
network: Don't remove bonding module on cleanup

Previously the bonding module got unloaded to remove all bonds on the
system, but this conflicted with other parts of Node, namely vdsm.
Therefor now the bonds are removed by bringing down each device on it's
own.

Change-Id: Ia2eada10beeb981ecf6b4dbe1b51d2c38f8daea7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=995155
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
network: Set type on bond masters

This is needed so NetworkManager is recognizing the configuration as a
bond master. Otherwise the bond device will not come up on Fedora 19.

Change-Id: Ia5907547058d9a08c8f06e70254b45a0fb4d7e42
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
network: Networking is also needed with bonds

Previously global networking was only enabled when a device got
configured, but networking is also required when a bond device is
created. Otherwise the bond device will not turn up in the system and
the UI.

Change-Id: I18d8eb775b08cf93e0024d597a4aa3c1044b4e89
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
add dynamic firewall creation for plugins

This reads in the firewall rules created under /etc/ovirt-plugins.d/$name.firewall

Within the firewall file should exist on each line "portnumber,protocol"
Change-Id: Ia6b364cba46afe490b1ab84ba8fe2f879eed4dcf
Signed-off-by: Joey Boggs <jboggs@redhat.com>
fix NoneType error when switch to performance page

Change-Id: Ib57895ec60bf9fb1eb3891efdcbadef173cb740f
Signed-off-by: boh.ricky <boh.ricky@gmail.com>
enhance cpe-name logic

determine it based on $VERSION in version.ks
Add ability to specify *type* of hypervisor

Format will be like :

cpe:/o:redhat:enterprise_linux:6:update5:hypervisor${TYPE}

Bug-Url:  https://bugzilla.redhat.com/988683
Bug-Url:  https://bugzilla.redhat.com/961331
Change-Id: Ie7c3c2e9ea9e147b0051e01543bcd8cdbc7b133c
Signed-off-by: Mike Burns <mburns@redhat.com>
Puppet page throws an exception when saving -- fix it

ovirt.node.utils.fs.File() has changed arguments -- we don't set
the mode any longer, but the puppet_page was doing so. Change it
to the new interface.

Change-Id: Ia565cdd81560b1d1655d1ec75af595960751fbfa
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=986789
Signed-off-by: Ryan Barry <rbarry@redhat.com>
fix password prompt typo

Change-Id: I1a41b65090d6b290944c110153ad1d95afbd303f
Signed-off-by: Joey Boggs <jboggs@redhat.com>
fix the miss parameter1 for label in install welcome page

Change-Id: Ieb1f9c795ae45a12f1d7e852edac68e04cbd4488
Signed-off-by: boh.ricky <boh.ricky@gmail.com>
Make sure the Puppet certificate name is a valid hostname or FQDN

The certname field is intended to submit a hostname other than
the actual hostname of the system in case it's desirable to
identify the node by a different name. Previously, we didn't
validate this. Do so.

Change-Id: I19ce15a30dad9487fff41fdc9aeb2c9f58c04e82
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987793
Signed-off-by: Ryan Barry <rbarry@redhat.com>
comment out firewalld sections until engine can support it

Change-Id: I3ae2f336eddfd6daee0e22039fb761029126f940
Signed-off-by: Joey Boggs <jboggs@redhat.com>
Fix "nomodeset" spelling mistakes in efi boot configuation

Change-Id: I67048f556f083c8abb699cf2ee242d8176ba0dc0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=995698
Signed-off-by: hadong <hadong0720@gmail.com>
network: Fix bridges for el6 and ifcfg

ifcfg can't ifup or ifup bridges unless /usr/sbin/brctl, that is
provided by bridge-utils is installed (Fedora19 does not install
it by default).

ip link del dev X type bridge is a not supported operation on
2.6.32 kernels that are found in el6 distros.

This patch fixes both things while keeping it compatible with
newer distros.

Change-Id: Ib798a5581191d835f68bd4324c2182ff28cab4a6
Signed-off-by: Antoni S. Puimedon <asegurap@redhat.com>