I touched the logic of the column index resolution (new method
tve.resolveColumnIndexesUsingSchema) in all aggregates and added all these
test-cases. You are absolutely right about the unused aliases. I removed
them but I would keep the test cases.


On Mon, Oct 14, 2013 at 4:38 PM, Paul A Martel <notifications@github.com>wrote:

> In tests/frontend/org/voltdb/planner/TestPlansJoin.java:
>
> > @@ -242,6 +249,60 @@ public void testScanJoinConditions() {
> >          assertEquals(ExpressionType.COMPARE_GREATERTHAN, p.getExpressionType());
> >      }
> >
> > +    public void testDisplayColumnFromUsingCondition() {
> > +        AbstractPlanNode pn = compile("select  max(A)  FROM R1 A JOIN R2 B USING(A)");
>
> These test cases are more stressing to the reader than to the planner --
> do we need these tests to have unused table aliases that happen to
> confusingly match column names? USING syntax is obscure enough all on its
> own.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/5/files#r6954919>
> .
>