Fix HAVE(QTTESTSUPPORT) logic

build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
resulting in HAVE(QTTESTSUPPORT) never being true.
Move that logic down in sanitizeFeatures.

Patch by Pierre Rossi <pierre.rossi@digia.com> on 2013-04-03
Rubber-stamped by Tor Arne Vestbø.

* qmake/mkspecs/features/features.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Unreviewed gardening. Updated platform specific expected files after r147492.

* platform/qt/TestExpectations:
* platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.png:
* platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
* platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
* platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
* platform/qt/fast/encoding/utf-16-big-endian-expected.png:
* platform/qt/fast/encoding/utf-16-big-endian-expected.txt:
* platform/qt/fast/encoding/utf-16-little-endian-expected.png:
* platform/qt/fast/encoding/utf-16-little-endian-expected.txt:
* platform/qt/fast/forms/input-value-expected.png: Added.
* platform/qt/fast/forms/input-value-expected.txt:
* platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.png:
* platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
* platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
* platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Remove defaultViewportArguments check from call site of recomputeVirtualViewportFromViewportArguments
https://bugs.webkit.org/show_bug.cgi?id=113872

Reviewed by Carlos Garcia Campos.

Carlos pointed out that recomputeVirtualViewportFromViewportArguments
already contains the check, and returns an empty IntSize if it fails.
So pick up on that to make the code a bit more DRY.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Fail gracefully if an OpenGL context could not be created.
https://bugs.webkit.org/show_bug.cgi?id=113784

In case we fail to create or adopt a valid platform OpenGL context
we do not want to provide a GraphicsContext3D instance.
Otherwise we would crash as soon as the instance is being used.

Reviewed by Jocelyn Turcotte.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Actions that require user gesture don't work in window.showModalDialog in Chromium
https://bugs.webkit.org/show_bug.cgi?id=113777

Reviewed by Jochen Eisinger.

In Chromium the window for showModalDialog is not modal which causes the
UserGestureIndicator to block actions in the sub window. We introduce a
RAII that saves the UserGestureIndicator and state, then resets it before
runModalDialog, and restore it when it's done.

No new tests. Can't cause user gesture inside modal dialog.

* dom/UserGestureIndicator.cpp:
(WebCore::UserGestureIndicatorDisabler::UserGestureIndicatorDisabler): Saves and resets the topmost indicator and state.
(WebCore):
(WebCore::UserGestureIndicatorDisabler::~UserGestureIndicatorDisabler): Restores topmost indicator and state.
* dom/UserGestureIndicator.h:
(WebCore):
(UserGestureIndicatorDisabler): RAII to temporarily disable UserGestureIndicator.
(UserGestureIndicator): Allow access to UserGestureIndicatorDisabler.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog): Disable UserGestureIndicator while runModalDialog.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Gstreamer] Avoid calls to g_slist_nth_data in webKitWebAudioSrcLoop()
https://bugs.webkit.org/show_bug.cgi?id=113875

Reviewed by Philippe Normand.

webKitWebAudioSrcLoop() was iterating over 2 GSLists by using a counter and then
calling g_slist_nth_data() to get the element of each GSList. This is inefficient
because calling g_slist_nth_data() will iterate the GSList up until index 'n'.

This patch improves this by keeping pointers to the current element of each list
while iterating, so that we can simply use g_slist_next() to iterate instead
of g_slist_nth_data().

No new tests, no behavior change.

* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed 32bit buildfix after r147542.

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveBinaryData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] WebKitWebNavigationAction: fix mix between dispose and finalize
https://bugs.webkit.org/show_bug.cgi?id=113794

Patch by Alban Crequy <alban.crequy@collabora.co.uk> on 2013-04-03
Reviewed by Gustavo Noronha Silva.

WebKitWebNavigationAction's dispose function was named finalize and was calling
the parent class's finalise function, causing a memory corruption. Change it to
be a proper finalize function instead.

* webkit/webkitwebnavigationaction.cpp:
(webkit_web_navigation_action_class_init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147557 268f45cc-cd09-0410-ab3c-d52691b4dbfc