yeah. But I really like to avoid passing null. I will fix the
DocumentationServer. I wonder why did not show up in my search.




On Mon, Apr 15, 2013 at 7:46 PM, James Roper <notifications@github.com>wrote:

> In framework/src/sbt-plugin/src/main/scala/PlayRun.scala:
>
> > @@ -134,10 +141,14 @@ trait PlayRun extends PlayInternalKeys {
> >          lazy val reloader = newReloader(state, playReload, applicationLoader)
> >
> >          val mainClass = applicationLoader.loadClass("play.core.server.NettyServer")
> > -        val mainDev = mainClass.getMethod("mainDev", classOf[SBTLink], classOf[Int])
> > +        val server = if(httpPort.isDefined) {
>
> Since we can't pass Option here because of the different Scala versions, I
> think it makes sense to make the mainDev method just accept
> java.lang.Integer, in which case we can pass null when http/https is
> disabled. I think that might be simpler.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/playframework/Play20/pull/1019/files#r3804163>
> .
>