netperf: fix a typo

We compute rpkt_per_exit by tx_pkts, and compute tpkt_per_exit
by rx_pkts. It's wrong.

Signed-off-by: Amos Kong <akong@redhat.com>
Merge pull request #1079 from kongove/for-lmr

Fix a typo in netperf result
virttest.libvirt_xml.pool_xml: Fix py 2.4 incompatible construct

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
virt: variable-rename fix for pylint

Signed-off-by: Chris Evich <cevich@redhat.com>
virt: Remove custom string conversion

Since PropcanBase is now fully pickle-able, there is no need
for custom string-conversion (which was used for pickling in virtnet).
Removed these special methods to just let normal python dict string
conversion take over.

Signed-off-by: Chris Evich <cevich@redhat.com>
virt-libvirt: libvirt_xml interface xml driver

Added ability to get/set/del '<model type=>' element + attribute.

Signed-off-by: Chris Evich <cevich@redhat.com>
virt-libvirt: Override base classcontains/has_key

There is a secondary set of propcan instances used behind the
scenes inside accessor factories.  Whenever they were trying
to retrieve non-existing data, or receive invalid input,
they toss a variaety of LibvirtXMLError exception sub-classes
by API design.  However, this doesn't jive with the standard
attribute/dictionary key-check method behavior.

The libvirt_xml API is defined such that all internally sourced
problems always throw a LibvirtXMLError exception or subclass.
However, since libvirt_base is also a propcan subclass, these
classes were get in the way of the regular python __contains__
and has_key() behavior.

This change makes LibvirtXML subclasses all conform to the python
dict and instance-attribute access convention.  Without it, one
would need to wrap the 'has_key()' call inside a try...except
LibvirtXMLError, which is unnatural.

Signed-off-by: Chris Evich <cevich@redhat.com>
virt-libvirt: Fix VMXML bug

Devices were not properly having the virsh instance
passed on to them.

Signed-off-by: Chris Evich <cevich@redhat.com>
virt-libvirt: virsh minor bugfix

The Virsh class automatically sucks in all callable
symbols found in the module and converts them into
methods.  However, an omission from the exclusion
list caused the VirshConnectBack class to be needlessly
exposed as a method (since classes are callable).
This has the potential to mess with unittests which
must mock Virsh methods, but at the same time may need
to use this class.  Adding it to the exclusion list
will prevent those problems.
virt: Add common import to virt_vm

I found a codepath through a unittest which causes
this module to load, before the common module is loaded.
Fortunately the fix is simple, and confirmed by unittest
results.

Signed-off-by: Chris Evich <cevich@redhat.com>
virt: Mass Unittests shared-state cleanup

Identified four unittests which were incorrectly
sharing state internally and externally.  In most
cases the fixes were simple: isolate test state
for every test via setup().  In the case of tests
needing to mock virsh functions, I took the extra
precautionary step of forcing them to first over-ride
ALL virsh functions/methods with an exception.
This way, any functions that should be mocked in
unittests but are not, will be immediatly clear :)

Signed-off-by: Chris Evich <cevich@redhat.com>
virt-libvirt: Fix interface XML driver

Fix duplication of 'type_name' property from base-class. In other
words, ``libvirt_xml/devices/base.py`` defines ``TypedDeviceBase``
which already handles setting up methods for ``get_type_name(),
set_type_name(), del_type_name()`` to work on device elements
``<device_name type='foobar'>``.  So there's no point in having a
subclass re-define accessor methods for the same ``type`` attribute.
Worse, it's using a python built-in (``type``) which encourages other
bad names down the stack.  I searched high and low for any usage of this
``type`` attribute and any calls to instance methods ``get_type(),
set_type(), and del_type()``  but found none.

Signed-off-by: Chris Evich <cevich@redhat.com>
virt: Codespell cleanup

Signed-off-by: Chris Evich <cevich@redhat.com>