Ok, makes sense :/


On Fri, Oct 4, 2013 at 3:54 PM, Donald Stufft <notifications@github.com>wrote:

> In test_ed25519.py:
>
> > +    sk = binascii.unhexlify(secret_key)
> > +    m = binascii.unhexlify(message)
> > +
> > +    pk = ed25519.publickey(sk)
> > +    sig = ed25519.signature(m, sk, pk)
> > +
> > +    # Assert that the signature and public key are what we expected
> > +    assert binascii.hexlify(pk) == public_key
> > +    assert binascii.hexlify(sig) == signature
> > +
> > +    # Validate the signature using the checkvalid routine
> > +    ed25519.checkvalid(sig, m, pk)
> > +
> > +    # Assert that we cannot forge a message
> > +    # TODO: Yes this means that we "pass" a test if we can't generate a forged
> > +    #   message. This matches the original test suite.
>
> I don't know if we do want it to be or not, it matches the original test
> suite and it fails without it because sometimes creating forgedm fails.
> I'm not sure if the logic creating forgedm is significant or not so I
> took the safer route of not changing things.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dstufft/ed25519/pull/4/files#r6781046>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084