just an attempt to apply inplace modification and return self in one step ;-)

let me write that differently, just override self.exclude and then return self. makes sense?

On 07.02.2013, at 18:37, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/preprocessing/ica.py:
> 
> > +            Additional list if tuples carrying the following parameters:
> > +            (name : str, target : str | array, score_func : callable,
> > +            criterion : float | int | list-like | slice). This parameter is a
> > +            generalization of the artifact specific parameters above and has
> > +            the same structure. Example:
> > +            add_nodes=('ECG phase lock', ECG 01', my_phase_lock_function, 0.5)
> > +
> > +
> > +        Returns
> > +        -------
> > +        self : instance of ICA
> > +            The ica object with the detected artifact indices marked for exclusion
> > +        """
> > +
> > +        logger.info('    Searching for artifacts...')
> > +        self = _detect_artifacts(self, raw, start_find, stop_find, ecg_channel,
> self =
> 
> return self
> 
> looks weird.
> 
> Can't you just return it?
> 
> —
> Reply to this email directly or view it on GitHub.
>