I simply translated over the equivalent version, however making `GroupPackageCount` optional makes sense.

If we make it optional, we'll have to give a way for each package to provide a `GroupPackageCount`, correct?

I wonder if we'll be forced to provide a way to identify groups of packages, as well.


On Tuesday, August 6, 2013 at 8:13 AM, Christopher Saunders wrote:

> In lib/active_shipping/shipping/carriers/fedex.rb:
> > rs << XmlNode.new('PackageCount', packages.size) > packages.each do |pkg| > - rs << XmlNode.new('RequestedPackages') do |rps| > + rs << XmlNode.new('RequestedPackageLineItems') do |rps| > + rps << XmlNode.new('GroupPackageCount', 1)  
> Should this really be a hardcoded value? We might want to make this optional and default to 1 when it's absent
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/Shopify/active_shipping/pull/96/files#r5606659).
>  
>  
>