fix off by one error

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8556 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
More work on support for inherited type qualifier annotations on methods.

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8557 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Changes to implement inherited type qualifier annotations.
Surprisingly, it actually seems to be working for return value
annotations.

One thing that is definitely not implemented is finding relevant
type qualifiers when both parameters and return type have
inherited type qualifier annotations.


git-svn-id: https://findbugs.googlecode.com/svn/trunk@8558 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Factored a new InheritanceGraphVisitor class, OverriddenMethodsVisitor,
out of AbstractMethodAnnotationAccumulator.  In general,
visiting all overridden methods is a useful thing to be able to do.

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8559 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Initial checkin

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8560 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Fix typo

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8561 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Add information about jsr-305 license.

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8562 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Added some javadoc.  Made the getDirectOrDefault... methods package-private.

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8563 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
When getting relevant type qualifiers for an instance method,
include any relevant type qualifiers for supertype methods.

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8564 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Fixed bug: SourceSinkInfo had an incorrect equals() method
that was only comparing locations, meaning that multiple
sources/sinks at same location were not modeled correctly.

Added some debugging code.

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8565 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Avoid multiple reports about same issue when a conflict arises
between a source and a sink that is the source's immediate
control successor.

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8566 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Improved reporting of type qualifier conflicts detected at
value source.

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8567 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Improved reporting of TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED
warnings.

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8568 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Improved reporting of TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED warnings.

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8569 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Added source code location for JSR305-ri classes.

Added some test cases for inherited type qualifier annotations.


git-svn-id: https://findbugs.googlecode.com/svn/trunk@8570 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
fix logic bug;
inheritance is a dag, not a tree; was causing asserts to fail

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8571 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
get rid of assert statement

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8572 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
Don't follow superclass edge from an interface to java.lang.Object

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8573 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
uniform use of OpcodeStackDetector

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8574 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3
properly record intentional confusing names

git-svn-id: https://findbugs.googlecode.com/svn/trunk@8575 eae3c2d3-9b19-0410-a86e-396b6ccb6ab3