My threading is making this hard to follow - I will respond via github

Paul Brian
paul@mikadosoftware
07540 456 115
twitter: @lifeisstillgood
skype: paul.mikadosoftware
Guiding you towards Continuous Delivery of software and business value.



On Tue, Mar 19, 2013 at 2:32 PM, Philip Schatz <notifications@github.com>wrote:

> In rhaptos2/repo/cnxbase.py:
>
> > +        else:
> > +            for usrdict in acllist:
> > +                # I am losing modified info...
> > +                self.adduserrole(userrole_klass, usrdict)
> > +
> > +    def adduserrole(self, userrole_klass, usrdict):
> > +        """ keeping a common funciton in one place
> > +
> > +        Given a usr_uuid and a role_type, update a UserRole object
> > +
> > +        I am checking setter_user is authorised in calling function.
> > +        Ideally check here too.
> > +        """
> > +        t = self.get_utcnow()
> > +
> > +        # why not pass around USerROle objects??
>
> I guess that I'm concerned that comments are meant to explain the code and
> asking this question did not help me understand the code.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Connexions/rhaptos2.repo/pull/91/files#r3432218>
> .
>

-- 


www.mikadosoftware.com

See your software improve with every change.