doc fix, test fix, test define_params