What is your point on suggesting "switch"?

i think compiler can handle this __NO_NEED_TO_FIRE_EVENT, used it for
readability.


On Fri, Nov 22, 2013 at 11:25 AM, Peter Veentjer
<notifications@github.com>wrote:

> In hazelcast/src/main/java/com/hazelcast/map/operation/EntryOperation.java:
>
> > @@ -87,17 +81,20 @@ else if (!entry.isModified()) {
> >              } else {
> >                  eventType = EntryEventType.UPDATED;
> >              }
> > -            dataValue = mapService.toData(entry.getValue());
> > -            recordStore.put(new AbstractMap.SimpleImmutableEntry<Data, Object>(dataKey, dataValue));
> > +            if (eventType != __NO_NEED_TO_FIRE_EVENT) {
>
> I would not use a __NO_NEED_TO_FIRE_EVENT to store a null and do a
> comparison on it. Just check for null.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hazelcast/hazelcast/pull/1192/files#r7851244>
> .
>