It really should be (instanceof Error) or its likely to cause confusion
down the line.  Micro-optimizing this seems wrong.

-- Dan


On Tue, Sep 3, 2013 at 9:52 PM, Xiao Ma <notifications@github.com> wrote:

> In lib/TimeoutError.js:
>
> > @@ -0,0 +1,15 @@
> > +// Copyright 2013 The Obvious Corporation.
> > +
> > +var util = require('util')
> > +
> > +/**
> > + * @constructor
> > + */
> > +function TimeoutError(msg) {
> > +  Error.captureStackTrace(this, TimeoutError)
> > +  this.message = msg || 'TimeoutError'
> > +}
> > +util.inherits(TimeoutError, Error)
>
> @don-neufeld <https://github.com/don-neufeld> Let me know if you really
> want me to remove the inheritance.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Obvious/zcache/pull/19/files#r6145077>
> .
>