No, I prefer the current syntax where it accepts both a single or list of
jobs.

I also have a preference for the term "dependency" (instead of
prerequisite). For one, it's more consistent with the term "dependent" and
it's also more commonly used in Python so people should be familiar with it.

I had to go so I didn't finish reviewing the entire PR, I'll try do a
comprehensive one later.


Sent from my phone

On Oct 13, 2013, at 10:58 AM, Joshua Chia <notifications@github.com> wrote:

In rq/job.py:

>          if depends_on is not None:
> -            job._dependency_id = depends_on.id if isinstance(depends_on, Job) else depends_on
> +            if isinstance(depends_on, Job) or isinstance(depends_on, text_type):

Do you think we should require depends_on to be a list so that this
conditional conversion to list can be omitted?

—
Reply to this email directly or view it on
GitHub<https://github.com/nvie/rq/pull/277/files#r6933519>
.