Take it up with dispatch :-)

I actually think the future won't fire an onFailure. I've asked for an either Future so dispatch will handle the onFailure case for me and return a Left.

Notice that these are just callbacks to handle the logging. Arguably I should do the logging from the code that maps responses, but it's nice to be able to include the request type and params etc in the log messages, which is why I've taken this approach. An alternative would be to convert the Future Response into an either myself, but since dispatch already does this it seems a shame to duplicate the code in EnrichedFuture.