We don't have to do things the same way as ohai, we can do it better. I
will discuss with Cary.


On Wed, Oct 16, 2013 at 12:57 PM, nobodyzzz <notifications@github.com>wrote:

> In lib/chef/plugins/cloud.rb:
>
> >
> >    # expecting public/private IPs to come from all clouds (but only if they
> >    # support instance-facing APIs).
> > -  public_ip4 = named_cloud_node[:"public-ipv4"] || named_cloud_node[:public_ipv4] || named_cloud_node[:public_ip]
> > -  private_ip4 = named_cloud_node[:"local-ipv4"] || named_cloud_node[:local_ipv4] || named_cloud_node[:private_ip]
> > -
> > -  # support the various cloud node keys found in ohai's cloud plugin.
> > -  # note that we avoid setting the value if nil (because we have some workarounds
> > -  # for clouds without instance-facing APIs).
> > -  if public_ip4
> > +  public_ip4 = cloud_node[:"public-ipv4"] || cloud_node[:public_ipv4] || cloud_node[:public_ip]
> > +  private_ip4 = cloud_node[:"local-ipv4"] || cloud_node[:local_ipv4] || cloud_node[:private_ip]
> > +
> > +
> > +  case cloud[:provider]
>
> The purpose of this case is to populate the same keys in cloud node as
> vanilla ohai cloud plugin does, so basically it just "copy-paste" from vanilla
> ohai<https://github.com/opscode/ohai/blob/master/lib/ohai/plugins/cloud.rb>cloud plugin
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rightscale/right_link/pull/258/files#r7013810>
> .
>