On Thu, Mar 07, 2013 at 03:32:45AM -0800, Jasper Van der Jeugt wrote:
> > @@ -56,8 +57,28 @@ data Configuration = Configuration
> >        inMemoryCache        :: Bool
> >      }
> >  
> > +instance Default Configuration where
> > +  def = Configuration
> 
> Why not just: `def = defaultHakyllConfiguration`? This removes some duplication. Additionally, indent by 4 spaces, like in the rest of the codebase.
> 

You could for example depreciate defaultHakyllConfiguration in the
next release and remove it in the subsequent release. In such a case
the current thing would be better. On the other hand if you want to
keep defaultHakyllConfiguration then yes stuff should be refactored.
Please let me know and I will send the request accordingly.

Regards

ppk


> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jaspervdj/hakyll/pull/116/files#r3278488