mips: Fixing some HReg <--> UInt mixups spotted by Florian.


git-svn-id: svn://svn.valgrind.org/vex/trunk@2670 8f6e269a-dfd6-0310-a8e1-e2731360e62c
The Coverity tool was run against the Valgrind source code and identified a
problem in VEX/priv/guest_ppc_toIR.c saying the variable 'insn_suffix' was
assigned but not used. The function _do_vsx_fp_roundToInt() has an
HChar * parameter named 'insn_suffix', and the intention of this function was
to set the insn_suffix appropriately for the passed opcode so that the caller
could use that suffix as needed (some callers needed, and others didn't).
However, since the parameter type is a simple pointer, passed by value,
insn_suffix was only modified locally, and the caller did not see the new
value. Since most of the callers of _do_vsx_fp_roundToInt() ignore the
insn_suffix, I have removed that from the parameter list and moved the code
for ascertaining the appropriate suffix into a new function called
_get_vsx_rdpi_suffix().

This patch is for Bugzilla 314099

The patch was written by Maynard Johnson.

The patch does not add any additional regtest errors.  The vbit tester 
was also run.  No issues were found.

The patch was reviewed, tested and committed by Carl Love




git-svn-id: svn://svn.valgrind.org/vex/trunk@2671 8f6e269a-dfd6-0310-a8e1-e2731360e62c