The problem is that having the Environment initialized before
settings_overrides is applied means that any custom template_path setting
is ignored.  The template_path used in the original code will always be the
default, regardless of what you set template_path to.  This keeps
everything in the settings dict, but allows for the user to override
template_path when the jinja2 environment is created.


On Thu, Aug 15, 2013 at 4:08 AM, Matthias Bussonnier <
notifications@github.com> wrote:

> In IPython/html/notebookapp.py:
>
> >          )
> >
> >          # allow custom overrides for the tornado web app.
> >          settings.update(settings_overrides)
> > +
> > +        # create a jinja2 environment using the template path and store it in settings
> > +        settings["jinja2_env"]=Environment(loader=FileSystemLoader(settings["template_path"]))
> > +
>
> Shouldn't that be above settings_override ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ipython/ipython/pull/4035/files#r5787706>
> .
>