I recommitted my stuff with just my code reformatted to the checkstyle
conventions.  Do I need to create a new pull request at this point?

Tx,

Eric



On Mon, Nov 4, 2013 at 2:15 PM, mck <notifications@github.com> wrote:

> In
> tiles-core/src/main/java/org/apache/tiles/definition/pattern/AbstractPatternDefinitionResolver.java:
>
> > @@ -106,4 +106,16 @@ private Definition searchAndResolveDefinition(
> >
> >          return d;
> >      }
> > +
> > +
> > +    /**
> > +     * Used to clear all entries in the localePatternPaths for a specific locale.  Necessary when reloading definition files
> > +     * to ensure that the list is cleared first
> > +     * @param customizationKey
> > +     */
> > +    @Override
> > +	public void clearPatternPaths( T customizationKey ){
> > +    	if( localePatternPaths != null && localePatternPaths.get(customizationKey) != null )
>
> No the codebase isn't perfect to begin with. But we don't want to make it
> worse.
>
> You pull request should not re-format other lines in the files in this
> pull request.
> It would be great to see a minimised diff, but of clean code.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/apache/tiles/pull/2/files#r7409899>
> .
>