No, I didn't; I did this before I was getting into common_page_data and
friends.   Could you explain your thinking w/r/t cache miss performance?
I'm intrigued.


On Wed, Jan 16, 2013 at 12:38 PM, Jason Bau <notifications@github.com>wrote:

> In main/courses/views.py:
>
> >              cg2_t = cg2.get_content_type()
> > -            level2_items.setdefault(cg2_t, []).append(getattr(cg2, cg2_t).id)
> > +            level2_items.setdefault(cg2_t, set([])).add(getattr(cg2, cg2_t).id)
>
> actually, quick question on this function. did you benchmark this function
> before and after your change here? This affects the cache miss performance,
> which I know is not critical, but would be good to know.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Stanford-Online/class2go/pull/1898/files#r2671924>.
>
>