done


On Fri, Nov 1, 2013 at 9:33 PM, Benjamin Eberlei
<notifications@github.com>wrote:

> In lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php:
>
> > +        $this->embeddedClasses[$mapping['fieldName']] = $this->fullyQualifiedClassName($mapping['class']);
> > +    }
> > +
> > +    /**
> > +     * Inline the embeddable class
> > +     *
> > +     * @param string $property
> > +     * @param ClassMetadataInfo $embeddable
> > +     */
> > +    public function inlineEmbeddable($property, ClassMetadataInfo $embeddable)
> > +    {
> > +        foreach ($embeddable->fieldMappings as $fieldMapping) {
> > +            $fieldMapping['declaredField'] = $property;
> > +            $fieldMapping['originalField'] = $fieldMapping['fieldName'];
> > +            $fieldMapping['fieldName'] = $property . "." . $fieldMapping['fieldName'];
> > +            $fieldMapping['columnName'] = $property . "_" . $fieldMapping['columnName'];
>
> No Doctrine\ORM\Mapping\NamingStrategy handles automatic naming of
> columns based on class and field names. However changing the interface is
> obviously a BC break. I think its small enough and easy enough to handle to
> make it, we need a mention in UPGRADE file though.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/doctrine/doctrine2/pull/835/files#r7380794>
> .
>