modify role finished