STYLE: remove extra comma

Copy/paste error left an extra comma in the argument list.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22582 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: add abiltiy to get displayable managers on 2d views

Added getDisplayableManagers on the slice view to mirror the
same call on the 3D view. Added testing.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22583 3bd1e089-480b-0410-8dfb-8563597acbee
STYLE: Improve readability of EXERCISE_BASIC_MRML_METHODS macro

This commit makes it easier to read through the different test
associated with the macro.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22584 3bd1e089-480b-0410-8dfb-8563597acbee
STYLE: Split MRML Node EncodeString tests into two different tests

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22585 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix vtkMRMLModelHierarchyNodeTest1

Since calling GetID() on a newly instantiated node is expected to
return NULL and that attempting to print a NULL string on windows
results in a crash. The test was failing only on windows.

This commit remove the print statement in the test and also add test
test for GetID and GetNodeTagName to EXERCISE_BASIC_MRML_METHODS so that
the default value for every node is verified.

Since there is already a test printing the value if it fails, also
remove extra debug statement printing the number of children in
the hierarchy node.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22586 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: adding a test to show layout switch bug

Fiducial display positions aren't updated correctly
on linux according to bug 1914. This test illustrates this in a
non failing test way so that cross platform behaviour can be
determined.

Issue #1914


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22587 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: check returned displayable managers

Add list of expected displayable managers and fail test
if returned list doesn't match in size or if returned managers
are not in the list.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22593 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix vtkMRMLSceneViewNodeStoreSceneTest randomly failing on windows

Allocating a single "vtkMRMLScalarVolumeNode" wasn't enough to ensure
that the space previously used by 'vtkMRMLScalarVolumeNode1' wasn't
available again for the restored volume.

See inlined comment for more details.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22594 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Attempt to fix random failure of qSlicerSslTest on windows

Execute the event loop just after queuing the request with the
networkAccessManager.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22597 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: Sync patch version to match latest stable release

See commit r22599 on Slicer-4-3 branch.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22600 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: test getting displayable managers to 3D view

To match the test added in svn 22583, make sure that
the expected list of displayable managers is present on the
3D view.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22602 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: 3436. Fixed node references to use predefined events. Made reference code similar between Diaplayable and Transformable references. This is also continuation of work on bug 3388.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22603 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: fixed problems and test failures introduced by r22603.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22604 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: #3438 Avoid hang when saving due to non-visible widget grab

If the OpenGL context of the window is not correctly initialized,
then VTK cannot get a copy of the pixels and goes into an
infinite loop checking the GL error.  This CTK version includes
a patch from Andras avoids this problem.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22605 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: see comment in r17038 of slicer3 trunk

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22606 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Read vectors as scalars

3-vectors were read as Vectors and placed on PointData.
All other vector lengths are read as multi-component Scalars
on PointData.

This patch treats all vectors as scalars to be consistent.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22607 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: add copy to markups list right click option

Can now right click on a markup in the GUI and copy it
to another list, placing it at the end of the destination
list.
Updated the right click Move option to only offer at the
end of the list as that simplifies the UI and users can
move the markups with the move up/down buttons.
Updated test for logic copy.
Updated documentation for copy.

Issue #3397



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22608 3bd1e089-480b-0410-8dfb-8563597acbee
STYLE: updated tool tip for markups table

Add a tool tip to hint at the right click context menu.

Issue #3397



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22609 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: 3416. Added generic mechanism for persisting node references in .mrml files. 
References stored in the form: references="role1:id1 id2 iid3;role2:id3;". Note that for backwards compatibility the  reference nodes such as displayable, transformable etc. still read/write their references the old way. Only custom references will use new syntax.


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22610 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: fix typo in AdditionalInitializeStep method name

Fixing a mis spelling in the additional initialize step method name.
In vtkMRMLAbstractDisplayableManager it's defined as:
AdditionalInitializeStep
but vtkMRMLCameraDisplayableManager was using:
AdditionnalInitializeStep
with an extra n. Using that signature, it was never getting called
so when new layout windows were being created, the active camera
was not getting set on the renderer.

Issue #1690



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22611 3bd1e089-480b-0410-8dfb-8563597acbee