Carlos, can you shed any light on this?


On 2013-08-01 12:53, David Mason wrote:
> In zanata-war/src/test/java/org/zanata/tmx/TMXParserTest.java:
> 
>> +   @BeforeMethod
>> +   public void initializeSeam()
>> +   {
>> +      seam.reset()
>> +          .ignoreNonResolvable()
>> +          .use("entityManager", getEm())
>> +          .use("session", getSession());
>> +   }
>> +
>> +   private TransMemory parseAndSaveTMFromFile(String file) throws XMLStreamException
>> +   {
>> +      TransMemoryDAO transMemoryDAO = seam.autowire(TransMemoryDAO.class);
>> +      TransMemory tm = new TransMemory();
>> +      tm.setSlug("new-tm");
>> +      tm.setDescription("New test tm");
>> +      transMemoryDAO.makePersistent(tm);
> 
> These lines must be doing something, yet the next line calls a method
> with the same name as this, suggesting that one of the methods is
> misnamed. Perhaps the next method in this chain should be called
> |populateTMFromFile(TransMemory tm, String file)| and this method should
> be |createAndPopulateTMFromFile(String file)|.
> 
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zanata/zanata-server/pull/78/files#r5521428>.
> 


-- 
Sean Flanigan

Senior Software Engineer
Engineering - Internationalisation
Red Hat