DERBY-6195: Cleanup encapsulation problems in ij.

git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1470982 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6185 (Query against view  with "where name LIKE 'Col1' ESCAPE '\' " failed)

During optimizer's pre-processing phase, while cloning a BinaryComparisonOperatorNode, we were not copying the entire state.



git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1471022 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6195:  Cleanup encapsulation problem in utilMain.

git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1471037 13f79535-47bb-0310-9956-ffa450edef68
DERBY-4729 add more information to the XACT_PROTOCOL_VIOLATION returned from sto
re.

When this error is reported it is often hard to reproduce, so adding
printing of internal state of the Transaction when it is hit.  Hopefully
this help in understanding what is going on when the error is hit.



git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1471079 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6197: Cleanup various encapsulation problems.

git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1471087 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6125 Code clean up in client driver.

derby-6125-rename-c which renames the name overloaded JDBC classes in
the client driver thus:

    am/<JDBCClassName>.java -> am/Client<JDBCClassName>.java

This allows import statements to be used for all JDBC and Derby
classes. The rest of the patch implements such usage instead of full
pathnames in usages. After this patch, the only overload that needs
explicit package path is "java.util.Date" which would otherwise
collide with java.sql.Date. In one instance, I let a full path remain
in order to avoid a compiler warning: the deprecated use of
StringBufferInputStream in ClientClob.java.



git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1471245 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6193: AutomaticIndexStatisticsTest doesn't delete its single-use database

Delete the extra database on successful completion. Also wrap the test
in a CleanDatabaseTestSetup so that it also cleans up the default
database when it's done.

git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1471264 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6196: ArrayIndexOutOfBoundsException in SURQueryMixTest

Make sure the random array index is never negative.

git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1471275 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6169: Reduce visibility of classes and methods under impl/sql

Stop exposing references to the internal array of saved objects in
GenericPreparedStatement by making the following changes:

- IndexRowToBaseRowResultSet: Since it doesn't need the complete
  array, make it use getSavedObject(int) instead of getSavedObjects()
  so that it only retrieves the single object that the caller is
  interested in.

- VTIResultSet: Remove code that may perform lazy initialization of
  one of the saved objects at run time if it was initially null.
  Instead, make sure it is initialized when the query is compiled.

- GenericPreparedStatement: Change getSavedObjects() to return a
  read-only view of the internal array, so that callers cannot
  accidentally modify it.

git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1471331 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6169: Reduce visibility of classes and methods under impl/sql

Remove unused methods and make DDColumnDependableFinder's constructor
package private.

git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1471382 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6200: Encapsulate the bytes in the eof marker for character streams.

git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1471562 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6201: Fix mutability issues in plan statistics package.

git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1471715 13f79535-47bb-0310-9956-ffa450edef68
DERBY-5866 ( testFiringConstraintOrder(org.apache.derbyTesting.functionTests.tests.lang.TriggerTest)junit.framework.AssertionFailedError: matching triggers need to be fired in order creation:1,NO CASCADE BEFORE,DELETE,ROW)

Adding more debugging info



git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1471721 13f79535-47bb-0310-9956-ffa450edef68
DERBY-5866 ( testFiringConstraintOrder(org.apache.derbyTesting.functionTests.tests.lang.TriggerTest)junit.framework.AssertionFailedError: matching triggers need to be fired in order creation:1,NO CASCADE BEFORE,DELETE,ROW)

I forgot to remove the forced failure from the test which I had used for debugging. Fixing the forced failure part with this commit.



git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1475624 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6202: Cleanup mutability issues in org.apache.derby.iapi.sql.dictionary package.

git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1475809 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6206: Cleanup encapsulation problems in NetworkServerControlImpl.

git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1475919 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6125 Code clean up in client driver. 

Javadoc fixup after changes in derby-6125-rename-01-c (svn 1471245).



git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1476040 13f79535-47bb-0310-9956-ffa450edef68
DERBY-6169: Reduce visibility of classes and methods under impl/sql

- Change visibility of all classes generated from sqlgrammar.jj to
  package protected.

- Make CompilerContextImpl.getParameterTypes() package protected since
  it's never called from outside the package.
DERBY-6169: Reduce visibility of classes and methods under impl/sql

- Make all fields of CreateViewNode private.

- Take a defensive copy in CreateViewNode.getProviderInfo() to prevent
  accidental modification by the caller.