change parms type to category which make code clearly