Well spotted.


On 5 August 2013 15:06, Adam Fisher <notifications@github.com> wrote:

> In identity/app/controllers/SignoutController.scala:
>
> > +
> > +import play.api.mvc._
> > +import play.api.data.Forms
> > +import model.IdentityPage
> > +import play.api.data.Form
> > +import common.ExecutionContexts
> > +import services.ReturnUrlVerifier
> > +import com.google.inject.{Inject, Singleton}
> > +import conf.IdentityConfiguration
> > +
> > +
> > +@Singleton
> > +class SignoutController @Inject()(returnUrlVerifier: ReturnUrlVerifier, conf: IdentityConfiguration) extends Controller with ExecutionContexts {
> > +
> > +  def signout = Action { implicit request =>
> > +    TemporaryRedirect(
>
> Turns out TemporaryRedirect is the wrong status code. We should generally
> use "SeeAlso".
>
> In this case TemporaryRedirect will work OK, but be aware it uses a 307
> which preserves the current request method (i.e. if the incoming request
> was a POST, the redirect is a POST too). We typically mean to change the
> request to a GET when we're redirecting so to reduce confusion (even though
> it'll be ok in this case) let's use SeeAlso everywhere unless we really
> mean not to (particularly given that 307 may not have amazing support in
> old clients).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/guardian/frontend/pull/1329/files#r5579291>
> .
>

Please consider the environment before printing this email.
------------------------------------------------------------------
Visit theguardian.com   

On your mobile, download the Guardian iPhone app theguardian.com/iphone and our iPad edition theguardian.com/iPad   
Save up to 32% by subscribing to the Guardian and Observer - choose the papers you want and get full digital access.
Visit subscribe.theguardian.com

This e-mail and all attachments are confidential and may also
be privileged. If you are not the named recipient, please notify
the sender and delete the e-mail and all attachments immediately.
Do not disclose the contents to another person. You may not use
the information for any purpose, or store, or copy, it in any way.
 
Guardian News & Media Limited is not liable for any computer
viruses or other material transmitted with or as part of this
e-mail. You should employ virus checking software.
 
Guardian News & Media Limited
 
A member of Guardian Media Group plc
Registered Office
PO Box 68164
Kings Place
90 York Way
London
N1P 2AP
 
Registered in England Number 908396

--------------------------------------------------------------------------