Update manifests per puppet-lint

* double space.
* single quote when appropriate.
* remove ';' from variables.
* use top scope variables.
Fix modulefile for puppetlabs.
Merge pull request #4 from nanliu/tb/cleanup

Update manifests per puppet-lint
Update dhcp module path for Ubuntu precise.

In Ubuntu precise, the dhcp dir is /etc/dhcp for isc-dhcp-server.

The changes have been only tested on precise. and I'm uncertain how far
back this change was put in place since the filelist have not changed:
http://packages.ubuntu.com/natty/amd64/isc-dhcp-server/filelist
http://packages.ubuntu.com/oneiric/amd64/isc-dhcp-server/filelist
http://packages.ubuntu.com/precise/amd64/isc-dhcp-server/filelist

Conflicts:
	manifests/params.pp
Merge pull request #6 from nanliu/tb/precise

Update dhcp module path for Ubuntu precise.
Change default log facility to daemon

This is the default configuration of ISC DHCP.  Using local7 is a site
specific preference.

The module should configure DHCP to operate and log in the default,
expected case.

Conflicts:

	manifests/init.pp
Remove dhcpd.conf.erb

Without this patch, it is confusing to use this module because the
dhcpd.conf.erb template is the intuitive place to look for the template
producing dhcpd.conf on the managed node.

This is not actually the case, the various fragments are used instead.

This patch removes the unused dhcpd.conf.erb template.

Conflicts:

	templates/dhcpd.conf.erb
Remove has_variable from templates

Without this patch the use of has_variable? in templates are causing
logic errors.  PXE configuration options are being added when they
should not be.

This patch replaces has_variable? with instance variables.  This fixes
the problem and correctly produces templates.

NOTE: The concat module assumes an empty string passed to content is the
same as content being undefined.  As a result, the template fragment
uses a static header comment to always make sure the string is not
empty.
Make all template fragments have header comments

Without this patch it is not clear which sections of the final
dhcpd.conf file come from which template fragements.

This patch fixes the problem by adding explicit BEGIN and END comments
to each fragment template.

This also has the benefit of ensuring every concat::fragment resource
has at least some content.  This is necessary to ensure the resource
doesn't think the content is undefined and switch to source processing
as a result.
Merge pull request #7 from jeffmccune/fix/master/templates

Make all template fragments have header comments
Make the dhcp module more reusable

Without this patch large portions of the dhcpd.conf are solely under the
control of the dhcp module itself.  This is a problem for 3rd parties
like myself who want to change some of the behavior configured in this
file by these resources.

This patch fixes the problem in a non-breaking way by exposing all of
the configuration file fragments flowing into dhcpd.conf as class
parameters of the main dhcp class.  3rd parties may now override the
header using their own content like so:

    class { dhcp:
      dhcp_conf_header => template("site/my_dhcpd.conf.header")
    }

Conflicts:

	manifests/init.pp
Whitespace only change to dhcp class defaults

Conflicts:

	manifests/init.pp
Merge pull request #8 from jeffmccune/feature/master/third_party_dhcpd_conf

Make the dhcp module more reusable
Send the client hostname to be used if unset

Without this patch the hostname is not being set based on the DHCP
offer.  This is using a relatively stock Debian Squeeze installation.
The hostname has been cleared from /etc/hostname

This patch requires an accompanying change to dhclient on the agent.
The following exit hook will properly set the hostname on Squeeze.

    # /etc/dhcp/dhclient-exit-hooks.d/hostname
    export PATH=/opt/puppet/bin:/usr/bin:/bin:/sbin:/usr/sbin:$PATH
    hostname $new_host_name
    puppet resource host $(facter fqdn) \
      ensure=present \
      ip=$(facter ipaddress) \
      host_aliases=$(facter hostname)
Merge pull request #9 from jeffmccune/feature/master/set_client_hostname

Send the client hostname to be used if unset
Merge pull request #5 from nanliu/tb/release

Fix modulefile for puppetlabs.
Whitespace only removal of comments
Merge pull request #10 from jeffmccune/fix/master/cleanup_comments

Whitespace only removal of comments
Added Redhat/CentOS package name
* Tested on CentOS6.0
Removed unwanted blank line