Yes.. there would be an extra \n, there has got to be a better solution but unfortunately, I don't have the time to look into it right now.

Thanks,
______________________________________
Eric Vautour
Senior Developer

[sigLogo]<http://www.kineticsocial.com/>

[twitter]<https://twitter.com/kineticsocial> [linkedin] <http://www.linkedin.com/company/2439007?trk=tyah>  [facebook] <https://www.facebook.com/kineticsocial>  [google] <https://plus.google.com/114356855356053837794/about>  [wordpress-logo] <http://kineticsocial.wordpress.com/>

Check out our new blog!

14 Duncan Street, Suite 202 | Toronto, ON M5H 3G8
o: 416-260-8882   |   f: 888.666.3120
http://www.kineticsocial.com/<http://www.kinetic-social.com/>

From: Erik Michaels-Ober <notifications@github.com<mailto:notifications@github.com>>
Reply-To: sferik/twitter <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Monday, November 18, 2013 5:44 AM
To: sferik/twitter <twitter@noreply.github.com<mailto:twitter@noreply.github.com>>
Cc: Eric Vautour <eric.vautour@kineticsocial.com<mailto:eric.vautour@kineticsocial.com>>
Subject: Re: [twitter] Added detection of split token (#481)


In lib/twitter/streaming/response.rb:

> @@ -23,6 +23,11 @@ def on_headers_complete(headers)
>        end
>
>        def on_body(data)
> +        # Ended with half a token \r and not \r\n and thus BufferedTokenizer will
> +        # not split the line correctly.  We need to ensure that each chunk of data passed
> +        # to BufferedTokenizer does NOT end with \r
> +        data += "\n" if data[-1] == "\r"


Won’t this cause there to be an extra \n?

—
Reply to this email directly or view it on GitHub<https://github.com/sferik/twitter/pull/481/files#r7720856>.

______________________________________________________________________
This email has been scanned by the Boundary Defense for Email Security System. For more information please visit http://www.apptix.com/email-security/antispam-virus
______________________________________________________________________

______________________________________________________________________
This email has been scanned by the Boundary Defense for Email Security System. For more information please visit http://www.apptix.com/email-security/antispam-virus
______________________________________________________________________