Should require an interface AND @ImplementedBy which rules out those pure
interfaces. Does that make sense? (Might need another push to make this be
the case however.)

Best,
Alex
On Jul 29, 2013 12:10 PM, "Aled Sage" <notifications@github.com> wrote:

> In core/src/main/java/brooklyn/catalog/internal/CatalogClasspathDo.java:
>
> >                  }
> >              } else if (scanMode==CatalogScanningModes.TYPES) {
> >                  Iterable<Class<? extends Entity>> entities = this.excludeInvalidClasses(scanner.getSubTypesOf(Entity.class));
> > -                for (Class<?> c: entities) {
> > -                    if (Application.class.isAssignableFrom(c))
> > +                for (Class<?> c: entities) {
> > +                    if (!c.isInterface())
>
> Not sure I follow this. For something like WebClusterDatabaseExampleApp,
> will this skip it because !c.isInterface(), but it will try to include
> things like the Application and StartableApplication interfaces in
> addCatalogEntry(...)?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/brooklyncentral/brooklyn/pull/855/files#r5446411>
> .
>